<p dir="auto">Test helper has two methods for login: <code class="notranslate">sign_in_as</code> and <code class="notranslate">session_for</code>. Which one do you use? The answer is <code class="notranslate">sign_in_as</code> in system test and <code class="notranslate">session_for</code> everywhere else. Why not then move <code class="notranslate">sign_in_as</code> to the system test base class? This class already has other methods and you won't be able to accidentally call <code class="notranslate">sign_in_as</code> from non-system tests.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4512'>https://github.com/openstreetmap/openstreetmap-website/pull/4512</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4512/commits/956ba386d684a8788eb3e96aa13fc82480b3f1c5" class="commit-link">956ba38</a>  Move system test specific sign in to system test superclass</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4512/files">2 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4512/files#diff-58be79ee432aa1a1e12529b3141879d9c9503ac6e071c47e2d53462d339362b7">test/application_system_test_case.rb</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4512/files#diff-ba37813ca277c227a74a372479b7b05b7f3ff085d890ab708f80d62573efdb7a">test/test_helper.rb</a>
    (9)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4512.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4512.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4512.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4512.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4512">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKXWNKRBVM6A6G5AKDYS6APXAVCNFSM6AAAAABDCYMKGWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZDQNBZHEYTOMY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJQZRTKGXTZLGG7HQTYS6APXA5CNFSM6AAAAABDCYMKGWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHH5XSR4U.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4512</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4512",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4512",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>