<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4524#discussion_r1493670303">config/locales/en-GB.yml</a>:</p>
<pre style='color:#555'>> @@ -2098,7 +2098,7 @@ en-GB:
site:
edit_tooltip: Edit the map
edit_disabled_tooltip: Zoom in to edit the map
- createnote_tooltip: Add a note to the map
+ createnote_tooltip: Add a note to the map.
</pre>
<p dir="auto">Please don't make changes to <code class="notranslate">en-GB.yml</code> or any other locale file other than <code class="notranslate">en.yml</code> as translations need to be done on Translatewiki not here.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4524#discussion_r1493670572">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -3095,7 +3096,7 @@ en:
site:
edit_tooltip: Edit the map
edit_disabled_tooltip: Zoom in to edit the map
- createnote_tooltip: Add a note to the map
+ createnote_tooltip: Add a note to the map.
</pre>
<p dir="auto">This was correct as it was - none of the other tooltips have a full stop.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4524#discussion_r1493670865">app/views/profiles/edit.html.erb</a>:</p>
<pre style='color:#555'>> @@ -43,6 +43,9 @@
<fieldset>
<legend><%= t ".home location" -%></legend>
<p id="home_message" class="text-muted m-0<% if current_user.home_location? %> invisible<% end %>"><%= t ".no home location" %></p>
+ <p class="text-muted m-0<% if current_user.home_location? %> invisible<% end %>">
+ <b><%= t(".home_location_warning") %></b>
</pre>
<p dir="auto">This change will no longer work as you've removed the <code class="notranslate">home_location_warning</code> string from the locale file - you were asked to move this to a separate PR which would have required moving both this and the string but instead you just removed the string from this PR and left this.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4524#pullrequestreview-1887136570">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNFEK7N4X3XUJP25MLYUG3U5AVCNFSM6AAAAABDNQGMW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBXGEZTMNJXGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMHGUR3O3AZEWFM543YUG3U5A5CNFSM6AAAAABDNQGMW6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTQPNVTU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4524/review/1887136570</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4524#pullrequestreview-1887136570",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4524#pullrequestreview-1887136570",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>