<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p dir="auto">Nice work, just a few small queries...</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4552#discussion_r1507914216">test/controllers/site_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -147,7 +147,7 @@ def test_permalink
 
     get permalink_path(:code => "wBz3--", :changeset => 4)
     assert_response :redirect
-    assert_redirected_to :controller => :browse, :action => :changeset, :id => 4, :anchor => "map=3/4.8779296875/3.955078125"
+    assert_redirected_to :controller => :changesets, :action => :show, :id => 4, :anchor => "map=3/4.8779296875/3.955078125"
</pre>
<p dir="auto">This can use <code class="notranslate">changeset_path</code> now I think?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4552#discussion_r1507916538">test/controllers/changesets_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -121,8 +125,9 @@ def test_index_bbox
   # Checks the display of the user changesets listing
   def test_index_user
     user = create(:user)
-    create(:changeset, :user => user)
-    create(:changeset, :closed, :user => user)
+    create(:changeset, :user => user, :num_changes => 1)
+    create(:changeset, :closed, :user => user, :num_changes => 1)
</pre>
<p dir="auto">Why does this need changes when neither the <code class="notranslate">index</code> action or the rest of this test has changed?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4552#discussion_r1507917096">test/controllers/changesets_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -121,8 +125,9 @@ def test_index_bbox
   # Checks the display of the user changesets listing
   def test_index_user
     user = create(:user)
-    create(:changeset, :user => user)
-    create(:changeset, :closed, :user => user)
+    create(:changeset, :user => user, :num_changes => 1)
+    create(:changeset, :closed, :user => user, :num_changes => 1)
+    user.reload
</pre>
<p dir="auto">Why do we need to reload the user? Is that to cause the cached changeset count on the user to update or something?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4552#pullrequestreview-1909432428">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIUKF2DDGUN62UWD6TYV5QKJAVCNFSM6AAAAABD7UBSHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBZGQZTENBSHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPUXJXRMKOSYLJC2VLYV5QKJA5CNFSM6AAAAABD7UBSHKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTRZ6QGY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4552/review/1909432428</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4552#pullrequestreview-1909432428",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4552#pullrequestreview-1909432428",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>