<p dir="auto">After element version paths were added to the website, <code class="notranslate">node_version_path</code> etc path helpers became confusing because they point to the api. Some of the api path helpers have the <code class="notranslate">api_</code> prefix, others don't. Ideally all of them should have it. Let's start with <code class="notranslate">*_version_path</code> which, if named similarly to web path helpers, should be <code class="notranslate">api_old_node_path</code>. Also controller actions, again if named similarly to web actions, should be <code class="notranslate">show</code> instead of <code class="notranslate">version</code> in this case. <code class="notranslate">OldNode</code> etc instances are already versions, it's strange to ask for a version of a version.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4557'>https://github.com/openstreetmap/openstreetmap-website/pull/4557</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/commits/e90e9fd99272e454929f58a095810a9e7e22c30a" class="commit-link">e90e9fd</a>  Rename api element version action to show</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/commits/9206fd8470b872c1585508effa7fe0ff9a835ba6" class="commit-link">9206fd8</a>  Rename api element version path helper</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files">17 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-341a1cf4f83cf00816b397c262181cd7b229f1c0e9210ba57dcef3f9609c1b74">app/abilities/api_ability.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-4ef53563daeea0b028628a6f604feb06ab240721814d3a78e8ef0679ff11014f">app/controllers/api/old_controller.rb</a>
    (4)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-48b4f006ada97664d38597136f9c54f378904d70007fc025462fdbda6071be9b">app/views/api/old_nodes/show.json.jbuilder</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-60ceb0ddcdf4d8faca268cf3a8d0be0ba2543dcc84320bd01cb8fc4a420e221b">app/views/api/old_nodes/show.xml.builder</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-2c4af32baf62ec98893b896084bceaf2478dfc78da9b392bf1e1c2080324a849">app/views/api/old_relations/show.json.jbuilder</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-04b9894855cacc554272d38aa4357b0639a777df2f820e68424200a32f2304d7">app/views/api/old_relations/show.xml.builder</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-2cb9882870011e209e64585d69d06b88633054a904dd23a26873ab89897fbfaa">app/views/api/old_ways/show.json.jbuilder</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-f4ae7b7e138b66306fbe50b0b77ce541e439785b0bd1f28e8d26eb003899b2c6">app/views/api/old_ways/show.xml.builder</a>
    (0)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-9cad8f09be9c4a039808cca13b691a28e8e1fd099b037731be8e01a29441e644">app/views/browse/_version_actions.erb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-7ee3168144cba950374d481967d27d39db360d6dfb366aa9033b42f32cb98256">test/controllers/api/old_nodes_controller_test.rb</a>
    (26)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-8e8190e84ed61c4b7d4457b6d491daae4fbe436431cd5985b364592d52271c68">test/controllers/api/old_relations_controller_test.rb</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-1d1ef6db64a5caea6f9e55e4038ed133a740c05263a5863c797fbfe26adc533e">test/controllers/api/old_ways_controller_test.rb</a>
    (25)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-da8c6d0ce9e50a5d0d4517cb17a60cc0df2f286b573ea8132fd903ad8c227237">test/controllers/api/relations_controller_test.rb</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-7d6a1fd4b66d6d5889edff2abba5c9532806a85a399adcf30a54d90f17a0ce71">test/controllers/old_nodes_controller_test.rb</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-2d036f37d3be755f748d43fc87df5ab0761ba872bed9e12b9fe001c62053d760">test/controllers/old_relations_controller_test.rb</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557/files#diff-d14579d9c1ef8dc82a2944bf60965e25d593ec1d4b1132256228eaf629ddbca1">test/controllers/old_ways_controller_test.rb</a>
    (12)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4557.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4557.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4557.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4557.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4557">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIQDRXRBG53G2ZPDILYWL4DVAVCNFSM6AAAAABED3EJQWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE3DKMRZGM2DCNI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLHEGDE3XXI6ZAEXSDYWL4DVA5CNFSM6AAAAABED3EJQWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHICD6BM4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4557</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4557",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4557",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>