<p></p>
<p dir="auto">So I'm not familiar with turbo at all beyond the quick look I've just had over lunch but in principle it looks nice and I don't have any objections - definitely not if it eventually lets us get rid of the client side router that nobody understands.</p>
<p dir="auto">I do think you probably chose a bad example to get started with... I can see why you chose it, because it's somewhere that is already manually doing partial updates but in order to preserve that behaviour you've wound up with a lot of really ugly stuff to handle the transitions 😞</p>
<p dir="auto">Possibly eventually that's something <a href="https://turbo.hotwired.dev/handbook/drive#view-transitions" rel="nofollow">view transitions</a> could handle better? They're not supported in firefox yet though...</p>
<p dir="auto">I suspect it would have been compelling to demonstrate what's possible with something like the diary entries or trace lists where I think you could pretty much just wrap the content in a turbo frame and get instant partial updates with no mess.</p>
<p dir="auto">One thing I'm unclear on is why we're installing turbo with npm when the <code class="notranslate">turbo-rails</code> gem already includes a copy which seems to be the <a href="https://turbo.hotwired.dev/handbook/installing" rel="nofollow">recommended</a> way to get it when using rails?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4562#issuecomment-1980929273">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI3WT33CGLHXXZITTLYW4N5BAVCNFSM6AAAAABEIVPY5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBQHEZDSMRXGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMSFNWVZA6EJPEQNVDYW4N5BA5CNFSM6AAAAABEIVPY5KWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTWCKKPS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4562/c1980929273</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4562#issuecomment-1980929273",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4562#issuecomment-1980929273",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>