<p></p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a> thanks for the quick and helpful feedback.</p>
<blockquote>
<p dir="auto">a lot of really ugly stuff to handle the transitions 😞</p>
</blockquote>
<p dir="auto">yes, true. I'd like to keep this extra stuff tightly packed together, so we can at least have it not become a remnant at some point in the future. I'll take tomorrow some time to tinker with this a bit.</p>
<blockquote>
<p dir="auto">Possibly eventually that's something <a href="https://turbo.hotwired.dev/handbook/drive#view-transitions" rel="nofollow">view transitions</a> could handle better?</p>
</blockquote>
<p dir="auto">👍🏽</p>
<blockquote>
<p dir="auto">One thing I'm unclear on is why we're installing turbo with npm when the turbo-rails gem already includes a copy which seems to be the <a href="https://turbo.hotwired.dev/handbook/installing" rel="nofollow">recommended</a> way to get it when using rails?</p>
</blockquote>
<p dir="auto">yes. good point. I started initially with just the npm-package because the turbo-rails gem brings a lot of helper code that was not even used in the first draft of the PR and everything works great without the gem. This PR just uses the <code class="notranslate">meta</code>-tag helper code from the gem.</p>
<p dir="auto">Then I figured it would be better to have the gem included since it provides access to even more helper-methods e.g. for Turbo Frames and just forgot to drop the npm-package.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4562#issuecomment-1984301115">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNBRBKCQBXISOJ75ILYXC7MFAVCNFSM6AAAAABEIVPY5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGMYDCMJRGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP7J3R43A3C2T4JXKDYXC7MFA5CNFSM6AAAAABEIVPY5KWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTWIYEDW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4562/c1984301115</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4562#issuecomment-1984301115",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4562#issuecomment-1984301115",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>