<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<p dir="auto">I'll try and have a fuller look later in the week but this is just a couple of things I noticed.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1519596772">app/assets/stylesheets/common.scss</a>:</p>
<pre style='color:#555'>> @@ -750,6 +750,11 @@ tr.turn:hover {
&.new-user-main {
background-image: image-url("sign-up-illustration.png");
+ background-position-x: 100px;
</pre>
<p dir="auto">I would probably make this more like 40-50 pixels - it stops the image being cropped on the right and also means more of it appears with a smallish phone screen.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1519599220">app/assets/stylesheets/common.scss</a>:</p>
<pre style='color:#555'>> @@ -750,6 +750,11 @@ tr.turn:hover {
&.new-user-main {
background-image: image-url("sign-up-illustration.png");
+ background-position-x: 100px;
+ }
+
+ &.new-user-blocked {
+ background-image: image-url("sign-up-illustration.png");
</pre>
<p dir="auto">I started off asking if this also needed the position attribute but found that led me into the fact that the whole <code class="notranslate">users/blocked</code> view probably needs to be updated to match the new login/signup layout.</p>
<p dir="auto">I've added an ACL to block the <code class="notranslate">blocked.example.com</code> domain on the test site so you can see what I mean by trying to signup with a <code class="notranslate">user@blocked.example.com</code> email.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#pullrequestreview-1927630619">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKNIQNEJIWBBR63FGTYXWL7DAVCNFSM6AAAAABBLOL2OWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRXGYZTANRRHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOTSIVWI5A7WDNYDM3YXWL7DA5CNFSM6AAAAABBLOL2OWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTS4VHRW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4455/review/1927630619</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#pullrequestreview-1927630619",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#pullrequestreview-1927630619",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>