<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4580#discussion_r1526433064">app/helpers/user_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -58,7 +58,11 @@ def openid_logo
def auth_button(name, provider, options = {})
link_to(
- image_tag("#{name}.svg", :alt => t("sessions.new.auth_providers.#{name}.alt"), :class => "rounded-3"),
+ image_tag("#{name}.svg",
+ :alt => t("sessions.new.auth_providers.#{name}.alt"),
+ :class => "rounded-3",
+ :width => "36px",
+ :height => "36px"),
</pre>
<p dir="auto"><code class="notranslate">px</code> shouldn't be in width/height attributes: <a href="https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#height" rel="nofollow">https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#height</a></p>
<p dir="auto">You can write <code class="notranslate">:size => "36x36"</code> instead: <a href="https://api.rubyonrails.org/classes/ActionView/Helpers/AssetTagHelper.html#method-i-image_tag-label-Options" rel="nofollow">https://api.rubyonrails.org/classes/ActionView/Helpers/AssetTagHelper.html#method-i-image_tag-label-Options</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4580#pullrequestreview-1939197119">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMRYMIG3AECOIV653LYYMFG7AVCNFSM6AAAAABEX7VEZGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMZZGE4TOMJRHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLL4IOXL6X3NFSLLCYTYYMFG7A5CNFSM6AAAAABEX7VEZGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTTSXGL6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4580/review/1939197119</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4580#pullrequestreview-1939197119",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4580#pullrequestreview-1939197119",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>