<p></p>
<p><b>@gravitystorm</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4248#discussion_r1532512549">app/controllers/changeset_comments_controller.rb</a>:</p>
<pre style='color:#555'>>    ##
   # Get a feed of recent changeset comments
-  def index
</pre>
<p dir="auto">As per discussion at <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2190983587" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4587" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4587/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4587">#4587</a> we should avoid creating new controller actions (or renaming existing ones) with non-resourceful names.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4248#discussion_r1532513067">app/controllers/concerns/pagination_methods.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,27 @@
+module PaginationMethods
</pre>
<p dir="auto">I like extracting this to a concern 👍</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4248#pullrequestreview-1949589767">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO722NCCSDG44AFHTTYZHBFTAVCNFSM6AAAAAA4YHSQ4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBZGU4DSNZWG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLO5N2PSZ4BT5A6JLO3YZHBFTA5CNFSM6AAAAAA4YHSQ4GWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTUGRQQO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4248/review/1949589767</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4248#pullrequestreview-1949589767",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4248#pullrequestreview-1949589767",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>