<p></p>
<p><b>@gravitystorm</b> requested changes on this pull request.</p>

<p dir="auto">This feels like a "one step forward, one step back" PR to me unfortunately.</p>
<p dir="auto">There's two parts in moving to resourceful routing, one part is using <code class="notranslate">resources</code> declaration in the routing file, but the other part is trying to have resourceful controller methods i.e. just index/show/new/create/edit/update/destroy , which the resources declarations use by default.</p>
<p dir="auto">In <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="378228775" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2050" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/2050/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/2050">#2050</a> (specifically <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/4b0d56f7e15d2929c973265e3b545e69273b8cb5/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/4b0d56f7e15d2929c973265e3b545e69273b8cb5"><tt>4b0d56f</tt></a>) I renamed the <code class="notranslate">comments_feed</code> (which is what was used when the code was in changesets_controller) to the <code class="notranslate">index</code> method, since that's what most closely aligns with what this doing i.e. showing a list of objects. So I'd like to keep this as a method named <code class="notranslate">index</code>.</p>
<p dir="auto">I realise that we still have <code class="notranslate">feed</code> methods elsewhere, but those are targets for refactoring too. There's a difficulty when there are already <code class="notranslate">index</code> methods that do different things (e.g. different lists of objects, or search filters, or other things, so in those cases it can't be as simple as just a <code class="notranslate">respond_to</code> switch) but in those cases I would prefer to see e.g. <code class="notranslate">FooController::index</code> and <code class="notranslate">Foo::FeedController::index</code> or similar, i.e. the method name is still <code class="notranslate">index</code>.</p>
<p dir="auto">See <a href="http://jeromedalbert.com/how-dhh-organizes-his-rails-controllers/" rel="nofollow">http://jeromedalbert.com/how-dhh-organizes-his-rails-controllers/</a> for more info.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4587#pullrequestreview-1949180161">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPX6W6OGY3A7MI6Q53YZGQ7VAVCNFSM6AAAAABE2UEXAWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBZGE4DAMJWGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNXV7ESZ5SGQA3C2VTYZGQ7VA5CNFSM6AAAAABE2UEXAWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTUFYQQC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4587/review/1949180161</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4587#pullrequestreview-1949180161",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4587#pullrequestreview-1949180161",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>