<p></p>
<p><b>@tordans</b> commented on this pull request.</p>

<p dir="auto">I don't know enough about he code but it looks like this likely duplicates some logic. Can this be shared in a concern or something similar?</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4605#discussion_r1533551887">app/controllers/api/messages_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,152 @@
+# The NodeController is the RESTful interface to Node objects
</pre>
<p dir="auto">Hint "NodeController"</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4605#discussion_r1533557724">lib/oauth.rb</a>:</p>
<pre style='color:#555'>> @@ -2,7 +2,7 @@ module Oauth
   SCOPES = %w[read_prefs write_prefs write_diary write_api read_gpx write_gpx write_notes].freeze
   PRIVILEGED_SCOPES = %w[read_email skip_authorization].freeze
   MODERATOR_SCOPES = %w[write_redactions].freeze
-  OAUTH2_SCOPES = %w[write_redactions openid].freeze
+  OAUTH2_SCOPES = %w[write_redactions message_send message_consume openid].freeze
</pre>
<p dir="auto">Would it be more consistent to have something like 'write_messages', 'read_messages'?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4605#pullrequestreview-1951532626">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMKUE6H3T27CYKYFVLYZKV5XAVCNFSM6AAAAABFBAKSFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJRGUZTENRSGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNYGL72SU23WF6TO6TYZKV5XA5CNFSM6AAAAABFBAKSFGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTUKIDFE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4605/review/1951532626</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4605#pullrequestreview-1951532626",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4605#pullrequestreview-1951532626",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>