<p></p>
<p><b>@milan-cvetkovic</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4605#discussion_r1535760898">app/controllers/api/messages_controller.rb</a>:</p>
<pre style='color:#555'>> + raise OSM::APIAccessDenied
+ end
+
+ @message.save!
+
+ # Return a copy of the message
+ respond_to do |format|
+ format.xml { render :action => :show }
+ format.json { render :action => :show }
+ end
+ end
+
+ private
+
+ def show_messages
+ if params[:min_id]
</pre>
<p dir="auto">I am not sure about this - how would the request for latest messages look like with <code class="notranslate">to</code> or <code class="notranslate">to_id</code>?</p>
<p dir="auto">get 10 messages in descending order, then get the following 10 messages in desc order (assuming the smallest id from 1st request was 1000):</p>
<pre class="notranslate"><code class="notranslate">GET /api/0.6/user/messages/inbox?to=0&limit=10
GET /api/0.6/user/messages/inbox?to=1000&limit=10
</code></pre>
<p dir="auto">instead of:</p>
<pre class="notranslate"><code class="notranslate">GET /api/0.6/user/messages/inbox?max_id=0&limit=10
GET /api/0.6/user/messages/inbox?max_id=1000&limit=10
</code></pre>
<p dir="auto">Here <code class="notranslate">max_id</code> would imply descending, it wouldn't be so obvious if the name of parameter is named <code class="notranslate">to</code> or <code class="notranslate">to_id</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4605#discussion_r1535760898">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJKOF4AEWRQVDCYPS3YZRDUFAVCNFSM6AAAAABFBAKSFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJVGA4TIMRSHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNFQHH7GCL4QWNXWGLYZRDUFA5CNFSM6AAAAABFBAKSFGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTURBPNK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4605/review/1955094229</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4605#discussion_r1535760898",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4605#discussion_r1535760898",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>