<p></p>
<p><b>@milan-cvetkovic</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1535447161">app/views/layouts/_header.html.erb</a>:</p>
<pre style='color:#555'>> @@ -104,7 +104,7 @@
           <%= link_to t("layouts.logout"), logout_path(:referer => request.fullpath), :method => "post", :class => "geolink dropdown-item" %>
         </div>
       </div>
-    <% else %>
+    <% elsif controller_name != "users" and controller_name != "sessions" %>
</pre>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/AntonKhorev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/AntonKhorev">@AntonKhorev</a> Interesting. It looks good to me, if we desire to keep the header buttons and tabs at the same time.</p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a></p>
<blockquote>
<p dir="auto">Alternatively, perhaps there is a better design solution, since removing these buttons on the full-width layout looks weird and slightly inconsistent to me.</p>
</blockquote>
<p dir="auto">There is a small inconsistency if we keep Login/Signup on the pages along with the tabs under the globe: The login buttons have different referrer:</p>
<ul dir="auto">
<li>login button in adds the referrer to the current page</li>
<li>login button in the tab keeps the referrer as originally set by initial "login" button that invoked it.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1535447161">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI67OPZ3A5IM36SNMDYZQKB3AVCNFSM6AAAAABBLOL2OWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJUGU4DKOJRGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPVVJ2YVCDCAQ7JPO3YZQKB3A5CNFSM6AAAAABBLOL2OWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTUQCOTQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4455/review/1954585912</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1535447161",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1535447161",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>