<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4628#discussion_r1541553838">app/controllers/traces_controller.rb</a>:</p>
<pre style='color:#555'>>  
-    if @trace&.visible? &&
-       (@trace&.public? || @trace&.user == current_user)
+    if @trace&.public? || @trace&.user == current_user
</pre>
<p dir="auto">I realise it's not a change from this PR but I don't think we need the conditional dereference here do we? The <code class="notranslate">find</code> will have raised an exception if nothing was found...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4628#pullrequestreview-1964028327">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJKINDHFFRAMLIUC2TY2LYMTAVCNFSM6AAAAABFKMU5P6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRUGAZDQMZSG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKTIYPGSGVKRBIV6FLY2LYMTA5CNFSM6AAAAABFKMU5P6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTVCCY2O.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4628/review/1964028327</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4628#pullrequestreview-1964028327",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4628#pullrequestreview-1964028327",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>