<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4640#discussion_r1546636986">test/models/node_test.rb</a>:</p>
<pre style='color:#555'>> @@ -362,4 +362,86 @@ def test_containing_relations
assert_equal relation_member2.relation.id, cr.second.id
assert_equal relation_member3.relation.id, cr.third.id
end
+
+ test "raises missing changeset exception when creating" do
</pre>
<p dir="auto">We should really be consistent and stick to using <code class="notranslate">do test_</code> or else change all the existing test definitions but I see some using this style have already snuck in without being noticed so I guess a few more won't hurt :-(</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4640#pullrequestreview-1971786070">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOSOMA2W3ULDLKDLODY3GL7VAVCNFSM6AAAAABFPLVDWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZRG44DMMBXGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLCSXGQ6SIX22HMWQTY3GL7VA5CNFSM6AAAAABFPLVDWOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTVQ4IVM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4640/review/1971786070</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4640#pullrequestreview-1971786070",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4640#pullrequestreview-1971786070",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>