<p dir="auto"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1383905010" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3715" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3715/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/3715">#3715</a> adds <code class="notranslate">ElementsController</code>. When I originally did it, I didn't notice that a similar superclass already exists for old elements because it's not named after elements.</p>
<p dir="auto">The name "OldController" is not specific enough because there are other "old" things besides old elements like old tags or old relation members.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4642'>https://github.com/openstreetmap/openstreetmap-website/pull/4642</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4642/commits/588b77244b6d77e667cc5ac0fd6d39b81df280e4" class="commit-link">588b772</a>  Rename api OldController to OldElementsController</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4642/files">4 files</a>)</p>
<ul>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4642/files#diff-9ef14ff2327785a0570c617732af322ddb45c3d931599b137e90fdf411dd9fd3">app/controllers/api/old_elements_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4642/files#diff-5c915480248573e6b15e3cda7cd7f941a88b941a4554397f001c6dcfe72178f5">app/controllers/api/old_nodes_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4642/files#diff-3fd28d91bfe2d275c9c82c5adec3bf67a339fafbccb5a40fd26c7390d0f16ac1">app/controllers/api/old_relations_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4642/files#diff-739114b998da8b3c6627439f6d9f3d658ef04f1c1733ca411cbbb4dbd4f410d4">app/controllers/api/old_ways_controller.rb</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4642.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4642.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4642.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4642.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4642">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMZYA27PDPVYVQP7MTY3KVY3AVCNFSM6AAAAABFTMFUDWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDANJQGY2TOOA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJQQFFU4FKQREDJ2XDY3KVY3A5CNFSM6AAAAABFTMFUDWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHIIWR52I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4642</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4642",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4642",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>