<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4617#discussion_r1552084041">app/controllers/application_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -206,13 +206,13 @@ def web_timeout(&block)
if e.is_a?(Timeout::Error) ||
(e.is_a?(ActiveRecord::StatementInvalid) && e.message.include?("execution expired"))
ActiveRecord::Base.connection.raw_connection.cancel
- render :action => "timeout"
+ render "browse/timeout", :layout => map_layout
</pre>
<p dir="auto">There are two controllers (changesets and changeset_comments) which have a timeout view already and with this change they will now render the browse timeout instead of their own one if they timeout? That was what I meant by breaking things that currently worked.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4617#discussion_r1552084041">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKNC4SRRBV62HP3R5TY3WBCLAVCNFSM6AAAAABFEK64GCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBQGU4TIMZWGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJLHXHH4EYWKCRWT2TY3WBCLA5CNFSM6AAAAABFEK64GCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTWBV4L2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4617/review/1980594365</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4617#discussion_r1552084041",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4617#discussion_r1552084041",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>