<p></p>
<p><b>@tordans</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4672#discussion_r1557687427">app/views/notes/index.html.erb</a>:</p>
<pre style='color:#555'>> @@ -24,19 +26,20 @@
</tr>
</thead>
<% @notes.each do |note| -%>
- <tr<% if note.author == @user %> class="table-primary"<% end %>>
- <td>
+ <% cell_class = submitted_class if note.author == @user -%>
+ <tr>
</pre>
<p dir="auto">In <a href="https://getbootstrap.com/docs/4.0/content/tables/#contextual-classes" rel="nofollow">https://getbootstrap.com/docs/4.0/content/tables/#contextual-classes</a> it looks like it should be possible to keep the classes on the <code class="notranslate">tr</code> which means all the added complexity with <code class="notranslate">submitted_class</code> could go away again in favor of inline classes.<br>
Would something like … be possible? (The code is probably not right, just to illustrate)</p>
⬇️ Suggested change
<pre style="color: #555">- <tr>
+ <%= tag.tr :class => ("bg-primary bg-opacity-25" if note.author == @user") do %>
+ // td|s
+ <% end %>
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4672#pullrequestreview-1989132663">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNZY3FPBGNREVBNSCLY4PYHLAVCNFSM6AAAAABF6UFNP6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBZGEZTENRWGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJBR37JKAKIXFTEMDLY4PYHLA5CNFSM6AAAAABF6UFNP6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTWR7AXO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4672/review/1989132663</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4672#pullrequestreview-1989132663",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4672#pullrequestreview-1989132663",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>