<p dir="auto">Version 3 of <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2233499530" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4672" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4672/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4672">#4672</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2241188569" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4693" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4693/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4693">#4693</a> which slightly changes light mode colors but probably nobody is going to notice it.</p>
<p dir="auto"><code class="notranslate">table-*</code> classes <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4693#discussion_r1564038196" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4693/hovercard">happen to use "subtle" background colors</a> that look fine in light mode. They <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4672#discussion_r1557742890" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4672/hovercard">don't adapt to dark mode</a> so we have to override them if we <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4669#issuecomment-2045718454" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4669/hovercard">still want to use them</a>. An obvious override is to set them to "subtle" colors in dark mode, that's what I tried in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2233499530" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4672" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4672/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4672">#4672</a> and it looks too dark. In this PR I'm doing the same thing I did in the legend abode the table and use the "non-subtle" color with 25% opacity.</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/assets/4158490/1283617a-6a24-4e5b-a311-14984fb520c6">image.png (view on web)</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4695'>https://github.com/openstreetmap/openstreetmap-website/pull/4695</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4695/commits/195507825a36ee6b967e14a0dfa153ef0d5652ac" class="commit-link">1955078</a> Adapt notes table to dark mode by overriding Bootstrap colors</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4695/files">2 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4695/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4695/files#diff-4fe647349351c7492508c788230b91b7f4445d4b821f6781ac7fcfad5e879f21">app/views/notes/index.html.erb</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4695.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4695.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4695.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4695.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4695">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOJBZ3WGKX7NXBLLZLY5E7PVAVCNFSM6AAAAABGFQRCJKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DCNJZGAYDONY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPSLXTDLHYDPTSYVUTY5E7PVA5CNFSM6AAAAABGFQRCJKWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHILG7THU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4695</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4695",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4695",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>