<p></p>
<p><b>@tordans</b> commented on this pull request.</p>
<p dir="auto">Visually, I like <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2233499530" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4672" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4672/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4672">#4672</a> more. I also like more, that the changes are contained to the one view template and not split up into css+view. But then again, I am a big fan of utility class css like Tailwind…</p>
<p dir="auto">If we go with this PR, I suggest to use the <code class="notranslate">sublte</code> term consistently and not overwrite "primary" with "primary-subtle".</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4693#discussion_r1563989803">app/assets/stylesheets/common.scss</a>:</p>
<pre style='color:#555'>> @@ -799,6 +799,15 @@ tr.turn:hover {
}
}
+/* Rules for notes pages */
+
+@include color-mode(dark) {
+ .notes .table-primary td {
</pre>
⬇️ Suggested change
<pre style="color: #555">- .notes .table-primary td {
+ .notes .table-primary-subtle td {
</pre>
<p dir="auto">And in <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4693/files#diff-4fe647349351c7492508c788230b91b7f4445d4b821f6781ac7fcfad5e879f21R27">https://github.com/openstreetmap/openstreetmap-website/pull/4693/files#diff-4fe647349351c7492508c788230b91b7f4445d4b821f6781ac7fcfad5e879f21R27</a> also <code class="notranslate">table-primary-subtle</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4693#pullrequestreview-1999251971">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLLOSQXPKXMQEBYGJTY5EPZ3AVCNFSM6AAAAABGFAS2Z6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOJZGI2TCOJXGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLO6MLM52ZD2MOFKAQ3Y5EPZ3A5CNFSM6AAAAABGFAS2Z6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTXFIVAG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4693/review/1999251971</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4693#pullrequestreview-1999251971",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4693#pullrequestreview-1999251971",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>