<p dir="auto">Assumptions:</p>
<ul dir="auto">
<li>We're committed to style tables with <code class="notranslate">table-*</code> classes as if Bootstrap supports dark mode.</li>
<li>Because Bootstrap actually doesn't support dark mode with <code class="notranslate">table-*</code> we want some isolated fix that's going to be removed once the support is there. This fix is in the changes to <code class="notranslate">common.scss</code>.</li>
<li>We don't want classes like <code class="notranslate">table-light</code> because we don't want table cells to stay light in dark mode. But this class was used in tags table for tag keys, so it has to be replaced with some other <code class="notranslate">table-*</code> class. It's replaced here with <code class="notranslate">table-secondary</code> although this makes tag key cells darker in light mode.</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4700'>https://github.com/openstreetmap/openstreetmap-website/pull/4700</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4700/commits/b5520a9b39ce7383178f3291188cae7519572688" class="commit-link">b5520a9</a> Use body color in notes table legend</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4700/commits/183dd443b2a0cf12981f39841740618ce69d4fcf" class="commit-link">183dd44</a> Use secondary color in tag key table column</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4700/commits/f7b76df47369a78110b03299ad2db59488fd0ff3" class="commit-link">f7b76df</a> Add dark mode overrides for Bootstrap table variants</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4700/files">3 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4700/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4700/files#diff-7400ae564f3281e220c5ff65433a4f0ea65a8db2a5bf20a377a63201c3c61e9f">app/views/browse/_tag.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4700/files#diff-4fe647349351c7492508c788230b91b7f4445d4b821f6781ac7fcfad5e879f21">app/views/notes/index.html.erb</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4700.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4700.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4700.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4700.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4700">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJFE6Z3PSE2HJ6TIHTY5KKULAVCNFSM6AAAAABGGGYJQGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DEMRQHA3DQMI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI7JOSWODXGUPISECTY5KKULA5CNFSM6AAAAABGGGYJQGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHILJLDVE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4700</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4700",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4700",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>