<p dir="auto">There is a <a href="https://getbootstrap.com/docs/5.3/helpers/icon-link/" rel="nofollow">Bootstrap class</a> for displaying icons next to links. Shared pagination has "<"/">" icons which could be attached using this class. But initially I didn't use it because it's named a bit deceptively.</p>
<p dir="auto">When we're on the first page, there's no link to the previous page yet we still want to attach the icon to the text in the disabled page item. Will <code class="notranslate">.icon-link</code> work in this case, without a link? Yes it will, Bootstrap <a href="https://github.com/twbs/bootstrap/blob/ad0cc68b7e226d9e1c1feb39ca68c0404c304365/scss/helpers/_icon-link.scss#L1">doesn't check</a> if <code class="notranslate">.icon-link</code> is used on a link or on anything else.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4706'>https://github.com/openstreetmap/openstreetmap-website/pull/4706</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4706/commits/61de77d49b14831e926699d81f111fac3713051a" class="commit-link">61de77d</a> Remove unnecessary .d-flex from shared pagination</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4706/commits/d0c871366cf2049c8d5e15e4bf9ca6200b9f29ff" class="commit-link">d0c8713</a> Use .icon-link in shared pagination</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4706/files">1 file</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4706/files#diff-2a43f1a5b4e2bda5df6ec18928f70304b3e1e3bcb084c26cc00d3ed34dab9062">app/views/shared/_pagination.html.erb</a>
(10)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4706.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4706.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4706.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4706.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4706">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPIDTVCEBRRLG4YCVDY5U5YVAVCNFSM6AAAAABGJR7QBWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DMMZQG43DENI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKAYI6AOMNJZOY3VYTY5U5YVA5CNFSM6AAAAABGJR7QBWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHILY7PFE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4706</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4706",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4706",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>