<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1574944284">app/controllers/users_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -101,14 +107,9 @@ def create
       if current_user.invalid?
         # Something is wrong with a new user, so rerender the form
         render :action => "new"
-      elsif current_user.auth_provider.present?
-        # Verify external authenticator before moving on
-        session[:new_user] = current_user.slice("email", "display_name", "pass_crypt", "pass_crypt_confirmation")
</pre>
<blockquote>
<p dir="auto">They would still have to click on "Sign up"</p>
</blockquote>
<p dir="auto">Yes, but right after that the user is written to the db with arbitrary <code class="notranslate">auth_provider</code>. That happens before any further confirmation.</p>
<blockquote>
<p dir="auto">If this is a real concern, I can bring back the extra round trip to the external provider before creating user record.</p>
</blockquote>
<p dir="auto">It's not the "extra" round trip when you allow to set <code class="notranslate">auth_provider</code> without any round trip. The deployed version has protections against that, you removed them here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1574944284">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJNVDRFQLQ27LCAQ23Y6UTCBAVCNFSM6AAAAABBLOL2OWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJVGA4TAOJYGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLITZRQXVLKNAYOVEALY6UTCBA5CNFSM6AAAAABBLOL2OWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTYDPMSS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4455/review/2015090985</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1574944284",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1574944284",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>