<p dir="auto"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2246999253" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4710" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4710/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4710">#4710</a> + <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2246390743" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4707" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4707/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4707">#4707</a> + all borders rounded. With this rounding the buttons won't be able to collapse into one block, there will always be a gap between "newer" and "older".</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/assets/4158490/bc682324-44f8-435d-ae4d-cdb3794ffc22">image.png (view on web)</a><br>
<a href="https://github.com/openstreetmap/openstreetmap-website/assets/4158490/4cbd2796-5530-44b3-be36-6b82e6f83b44">image.png (view on web)</a><br>
<a href="https://github.com/openstreetmap/openstreetmap-website/assets/4158490/c297922b-26a2-4462-9d41-67f924984d30">image.png (view on web)</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4729'>https://github.com/openstreetmap/openstreetmap-website/pull/4729</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/commits/1cc2dde83b10c4cff18c7356280788a945f7603b" class="commit-link">1cc2dde</a> Pass translation scope instead of keys to shared pagination</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/commits/1c81c6f984289d1ba92d044094b8c409956cc3f9" class="commit-link">1c81c6f</a> Introduce pagination item helper</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/commits/d38ce5411324e32a1df29f9af9d503fe3d250992" class="commit-link">d38ce54</a> Replace previous/next page selectors with helper methods in tests</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/commits/003efd8e0a1b9e11e0216831b2b492eeb2f19812" class="commit-link">003efd8</a> Add oldest/newest links to shared pagination</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/commits/2962f314f61c6842dd815329cf0f764b77d8a706" class="commit-link">2962f31</a> Show only pagination icons below medium/small screen sizes</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/commits/99f18be5c9b5d783c2a112b87c1f91561ffecf96" class="commit-link">99f18be</a> Move next/last page buttons to the right side</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files">10 files</a>)</p>
<ul>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-f2a534b6a0c6d93a6d4e0b15824e55cfc3fc6458fa0789e62d409d56c99dc189">app/helpers/pagination_helper.rb</a>
(13)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-fb860a130fe8ce948cdb98e2ba4b0c9d947f351dc9a55a12fff9d02ca61b0568">app/views/diary_entries/comments.html.erb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-aad6c85558af2a77937df72b074ef1a972b08171986d4dbddf0c86d0cf83a3f5">app/views/diary_entries/index.html.erb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-2a43f1a5b4e2bda5df6ec18928f70304b3e1e3bcb084c26cc00d3ed34dab9062">app/views/shared/_pagination.html.erb</a>
(44)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-446cb1205994b7918b2a68c30feb162b10fce3a0a9e05c716d9e966df4ba0507">app/views/traces/index.html.erb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-c168d2324bc74e9bd639f796e23def66db563d9457b7d4a2c05b109552804a4c">app/views/user_blocks/_blocks.html.erb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-2f2f2a0bc9c3675306c20ed740c32fad7b057eae15952a8dd2455d3eb661a49f">app/views/users/index.html.erb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(28)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-10a5c4533814c8b1222f0ef0833c82edd68584d85757fc431557b39813777c19">test/controllers/diary_entries_controller_test.rb</a>
(45)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729/files#diff-db7c9d7ea4afdcafd812aac88f5a378c22117fbce829dc93d905152f2c09f471">test/controllers/traces_controller_test.rb</a>
(76)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4729.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4729.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4729.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4729.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4729">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ64E6WBMYVTYU3KA3Y7MSS5AVCNFSM6AAAAABG3YSRUGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DMOBTGMYTKMQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMENP67V7JO7FRGEXTY7MSS5A5CNFSM6AAAAABG3YSRUGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHIOHJBAA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4729</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4729",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4729",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>