<p></p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a></p>
<blockquote>
<p dir="auto">as you can see in that image the text alongside the preferred provider is not well aligned vertically relative to the icon which in turn means the icon is visibly closer to the bottom border than the top one.</p>
</blockquote>
<p dir="auto">This should be fixed now, thanks.</p>
<blockquote>
<p dir="auto">I don't think it's good to put it above the header like that - nothing else on the site does that or causes the header to move down like that.</p>
</blockquote>
<p dir="auto">The <a href="https://github.com/openstreetmap/openstreetmap-website/issues/4128#issuecomment-1675045559" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/4128/hovercard">design document</a> actually has a light grey divider line above the div with the text "Sign up with OpenStreetMap to access..." text. I missed that, so it all became white.</p>
<p dir="auto">Here is the reasoning why the design is with the text on top:</p>
<ul dir="auto">
<li>the instructions to sign up or log in are presented before the choice of actions (Sign Up and Log In tabs)</li>
<li>the user comes to this page while trying to do an action on a 3rd party app - it might be surprising "why am I here?" The first thing they should see is the explanation- which "Sign up with OSM to continue with your app...." or "Login to OSM to continue with your app..." is trying to do</li>
<li>The text stripe is above the globe image because the tabs are embedded into the Globe image.</li>
</ul>
<blockquote>
<p dir="auto">I would suggest moving it and having it replace the generic "Sign up to get started contributing." text with the client specific call to action. That is obviously a less prominent position (though putting it above the header actually also makes it hard to notice or did for me) so maybe it should be bolded or emphasised in some other way.</p>
</blockquote>
<p dir="auto">I also have the feeling that the text is almost unnoticable, but I am not sure where to move it. If we keep it where on top of the globe image, we could potentially make it more noticable, perhaps by different background colour. I doubt that an additional grey line as originally suggested would do the trick.</p>
<p dir="auto">Here are the original design and proposed design with more prominent background, similar to how <code class="notranslate">flash</code> notice looks (both designs have incomplete top navigation bar):</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/assets/99971018/f6c015a7-bc11-4a0a-a588-9ff20351adf5">image.png (view on web)</a></p>
<p dir="auto">Proposed design:<br>
<a href="https://github.com/openstreetmap/openstreetmap-website/assets/99971018/94cbc856-9229-488d-9a92-1d8cb8129db3">image.png (view on web)</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#issuecomment-2083306605">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMVDSVRIUR3234WKA3Y72BPPAVCNFSM6AAAAABBLOL2OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTGMYDMNRQGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMMXSE7CZHI274M773Y72BPPA5CNFSM6AAAAABBLOL2OWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT4FS6G2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4455/c2083306605</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#issuecomment-2083306605",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#issuecomment-2083306605",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>