<p dir="auto">Elements, changesets, notes had constraints in their id parameter in routes. <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/9748ce301c9488b9cd32439448770c3d4a38ebd6/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/9748ce301c9488b9cd32439448770c3d4a38ebd6"><tt>9748ce3</tt></a> removed this constraint for notes for unknown reason. Without this constraint notes controller needs different tests. The part of "browse_check" that checks negative ids had to be commented out.</p>
<p dir="auto">This PR restores the constraint which allows to use the same "browse_check" as for every other entity formerly handled by browse controller.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4746'>https://github.com/openstreetmap/openstreetmap-website/pull/4746</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4746/commits/eaacfbb91198bcf5d14e25fa64b3515f889e0d75" class="commit-link">eaacfbb</a>  Restore constraints on note id parameter</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4746/commits/f554e14b7f648d32145ec63178df4b2a17583ce2" class="commit-link">f554e14</a>  Use common sidebar_browse_check in notes controller test</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4746/files">2 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4746/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4746/files#diff-b41a560e061b578bbf13158bf175036a9489241ab69f59137c44d57df9682fa7">test/controllers/notes_controller_test.rb</a>
    (54)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4746.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4746.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4746.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4746.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4746">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPZFA6T2KHQHPFE3J3ZADAC5AVCNFSM6AAAAABHBY3642VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TGMRZG4ZTEMQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMWGBKIEZT44HYIMYDZADAC5A5CNFSM6AAAAABHBY3642WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHIO76DVI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4746</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4746",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4746",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>