<p dir="auto">Remove tests with "... with no ID should fail ... assert_response :success" and like. They don't do what their comments say and never test missing ids.</p>
<p dir="auto">Rails is being <a href="https://thoughtbot.com/blog/avoid-making-path-helpers-guess" rel="nofollow">smart with path helpers</a> here. It sees that an id is missing and it uses the id from the previous request.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4753'>https://github.com/openstreetmap/openstreetmap-website/pull/4753</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4753/commits/926788ff9a2e3b34d1a6445d3a68ce7c614ef615" class="commit-link">926788f</a>  Remove tests for message paths without ids</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4753/files">1 file</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4753/files#diff-ddf5d19fd2916b2a385e2be7541e2229667490427938e04c2e1fdf1d1517385c">test/controllers/messages_controller_test.rb</a>
    (16)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4753.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4753.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4753.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4753.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4753">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO2Q2JPWKNQOMOGUWDZAY6EPAVCNFSM6AAAAABHHYQ5DCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TSNJVG4ZDEMY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKM66SSDZEZBTDX2G3ZAY6EPA5CNFSM6AAAAABHHYQ5DCWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHIPX2IM4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4753</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4753",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4753",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>