<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4795#discussion_r1600764774">app/helpers/user_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -74,7 +74,8 @@ def auth_button_preferred(name, provider, options = {})
image_tag("#{name}.svg",
:alt => t("application.auth_providers.#{name}.alt"),
:class => "rounded-1 me-3",
- :size => "24") + t("application.auth_providers.#{name}.title"),
+ :width => "24px",
+ :height => "24px") + t("application.auth_providers.#{name}.title"),
</pre>
<p dir="auto">This was only just changed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/b4f719a8c58c5177fe3dbc330fc90b3e0ef94c4c/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/b4f719a8c58c5177fe3dbc330fc90b3e0ef94c4c"><tt>b4f719a</tt></a> to make it consistent with the <code class="notranslate">auth_button</code> method so why are we changing it back again?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4795#pullrequestreview-2056617898">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLODZZXQVX34WIN7DTDZCKKELAVCNFSM6AAAAABHWUZPPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJWGYYTOOBZHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKOHKOBRCLVDEIUI2DZCKKELA5CNFSM6AAAAABHWUZPPKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT2SV72U.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4795/review/2056617898</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4795#pullrequestreview-2056617898",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4795#pullrequestreview-2056617898",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>