<p></p>
<p dir="auto">OK, this looks fine to me.</p>
<p dir="auto">I had to do some reading as to the differences between OAuth 1.0 vs 1.0a, and also (re-)learning about how the rails filter chains work since it wasn't initially obvious to me that rendering in the filter was enough to stop the rest of the action from running too.</p>
<p dir="auto">It's a little complex to understand how the <code class="notranslate">Settings.oauth_10_support</code> and <code class="notranslate">Settings.oauth_10a_support</code> interact, since the second also affects oauth 1.0 tokens, but hopefully we can clean this up soon. In reality, OAuth 1.0 is already turned off anyway.</p>
<p dir="auto">With regards to Basic Auth, we'll need to do some work to remove usage of basic_auth in our tests in the near future.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4496#issuecomment-2112871787">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNHT3FPIKWR46N42ADZCN56HAVCNFSM6AAAAABCLFRSQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSHA3TCNZYG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJRKAZMOSKI7K6TVVTZCN56HA5CNFSM6AAAAABCLFRSQKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT557OWW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4496/c2112871787</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4496#issuecomment-2112871787",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4496#issuecomment-2112871787",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>