<p dir="auto">It does not add any additional guards against malicious users:</p>
<p dir="auto">Malicious user may attempt to invoke <code class="notranslate">POST /users/new</code> with bogus values for <code class="notranslate">auth_provider</code> and <code class="notranslate">auth_uid</code> resulting with a new account to which user would have a way to login, other than sending a password reset request.</p>
<p dir="auto">In some cases, re-authorization would introduce additional "Please login to your social account", or "Are you sure you want to be logged in" popup triggered by identity provider.</p>
<p dir="auto">This PR removes the re-authorization request from <code class="notranslate">POST /users/new</code> in authorization flow.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4847'>https://github.com/openstreetmap/openstreetmap-website/pull/4847</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4847/commits/537dd54f80563d1e9ecd7ad4b022b2d91a2023de" class="commit-link">537dd54</a>  Social sign-in: avoid re-authorization in `users_controller#create`</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4847/files">2 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4847/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4847/files#diff-19aa16b7c7e0598a9b16e64733cafc53ac88bc34c658524342c0a0bffde8affc">test/integration/user_creation_test.rb</a>
    (189)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4847.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4847.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4847.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4847.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4847">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJC5J2DP36DUUPMUQTZEN5LDAVCNFSM6AAAAABILTV2DOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTSNRTHE4TONA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM6YKZ2NSRVOMFJJ43ZEN5LDA5CNFSM6AAAAABILTV2DOWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHIUQXFUY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4847</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4847",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4847",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>