<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>
<p dir="auto">This moves the line relative to the <code class="notranslate">or</code> text so the line is more or less aligned with the bottom of the text but I think it's better when the line is aligned with the middle of the text? I don't think the old version quite has them perfectly middle aligned but it's certainly a lot closer than this.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4857#discussion_r1619210402">app/views/sessions/new.html.erb</a>:</p>
<pre style='color:#555'>> @@ -27,7 +27,7 @@
<%= render :partial => "auth_providers" %>
<div class="d-flex justify-content-center align-items-center">
<div class="border-bottom border-1 flex-grow-1"></div>
- <div class="text-secondary mx-3"><%= t ".or" %></div>
+ <div class="text-secondary mx-3 mb-2"><%= t ".or" %></div>
</pre>
<p dir="auto">Was there a reason for choosing the <code class="notranslate">mb-2</code> rather than <code class="notranslate">mb-3</code> that <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> suggested?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4857#pullrequestreview-2085952948">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPFEETXYLVJB4NUXZDZEYCLHAVCNFSM6AAAAABIOSRRG6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBVHE2TEOJUHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI73CPCYZCZ55MU5DLZEYCLHA5CNFSM6AAAAABIOSRRG6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT4KUO3I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4857/review/2085952948</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4857#pullrequestreview-2085952948",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4857#pullrequestreview-2085952948",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>