<p dir="auto">If you have multiple alter commands in a migration (like adding two columns to an existing table) this cop will suggest combining them using <code class="notranslate">change_table :foo, :bulk => true</code>.</p>
<p dir="auto">However, Strong Migrations can't inspect <code class="notranslate">change_table</code> blocks, and therefore suggests using <code class="notranslate">safety_assured</code>, which mostly defeats the purpose of using Strong Migrations in the first place.</p>
<p dir="auto">Instead, we should stick with the individual alter commands. Since postgres runs DDL changes in a transaction anyway, there is not enough benefit from the <code class="notranslate">change_table</code> approach to be worth losing the safety net of the Strong Migrations checks.</p>
<ul dir="auto">
<li>Refs <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1419107898" data-permission-text="Title is private" data-url="https://github.com/ankane/strong_migrations/issues/204" data-hovercard-type="issue" data-hovercard-url="/ankane/strong_migrations/issues/204/hovercard" href="https://github.com/ankane/strong_migrations/issues/204">ankane/strong_migrations#204</a></li>
<li>Refs <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2083003572" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4481" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4481/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4481">#4481</a></li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4913'>https://github.com/openstreetmap/openstreetmap-website/pull/4913</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4913/commits/f1fc31d485eb310781600645df43b3f45a76fd57" class="commit-link">f1fc31d</a> Disable Rails/BulkChangeTable cop</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4913/files">1 file</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4913/files#diff-4f894049af3375c2bd4e608f546f8d4a0eed95464efcdea850993200db9fef5c">.rubocop.yml</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4913.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4913.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4913.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4913.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4913">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOHVE2DJUNN6EWKH5LZIG2GVAVCNFSM6AAAAABJSNLKFWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3DEOBQGQYDOMY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLK5VTRB4PD3VCXO2W3ZIG2GVA5CNFSM6AAAAABJSNLKFWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHIZVMHNE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4913</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4913",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4913",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>