<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4894#discussion_r1660332387">app/assets/javascripts/richtext.js</a>:</p>
<pre style='color:#555'>> + if (editor.val().length === 0) {
+ var messageTitleElement = document.getElementById("message_title");
+ if (messageTitleElement) {
+ messageTitleElement.removeAttribute("required");
+ }
+
+ var diaryEntryTitleElement = document.getElementById("diary_entry_title");
+ if (diaryEntryTitleElement) {
+ diaryEntryTitleElement.removeAttribute("required");
+ }
+
+ return;
+ }
+
</pre>
<p dir="auto">I don't necessarily agree that triggering the validation is a good idea, but if you really want to do it, you can just call <code class="notranslate">reportValidity</code> on an input:</p>
⬇️ Suggested change
<pre style="color: #555">- if (editor.val().length === 0) {
- var messageTitleElement = document.getElementById("message_title");
- if (messageTitleElement) {
- messageTitleElement.removeAttribute("required");
- }
-
- var diaryEntryTitleElement = document.getElementById("diary_entry_title");
- if (diaryEntryTitleElement) {
- diaryEntryTitleElement.removeAttribute("required");
- }
-
- return;
- }
-
+ event.preventDefault();
+
+ if (!editor[0].reportValidity()) {
+ return;
+ }
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4894#pullrequestreview-2150220708">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNTWFXDPLF75H5NIJDZKCKATAVCNFSM6AAAAABJJ546QSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJQGIZDANZQHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNYIR7KF3PZXLI72K3ZKCKATA5CNFSM6AAAAABJJ546QSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUAFHB2I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4894/review/2150220708</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4894#pullrequestreview-2150220708",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4894#pullrequestreview-2150220708",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>