<p></p>
<p><b>@AntonKhorev</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4935#discussion_r1665099365">app/views/sessions/new.html.erb</a>:</p>
<pre style='color:#555'>> +    <div class="d-flex flex-wrap column-gap-3 justify-content-between align-items-baseline">
+      <%= f.label :password, t(".password"), :class => "my-2" %>
</pre>
<p dir="auto"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2383674478" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4935" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4935/hovercard?comment_id=1661380070&comment_type=review_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/4935#discussion_r1661380070">#4935 (comment)</a> talks about the height of the whole row, yet the margin is applied just to the label. Why not:</p>
⬇️ Suggested change
<pre style="color: #555">-    <div class="d-flex flex-wrap column-gap-3 justify-content-between align-items-baseline">
-      <%= f.label :password, t(".password"), :class => "my-2" %>
+    <div class="d-flex flex-wrap column-gap-3 justify-content-between align-items-baseline mb-2">
+      <%= f.label :password, t(".password") %>
</pre>

<p dir="auto">Before/after:<br>
<a href="https://github.com/openstreetmap/openstreetmap-website/assets/4158490/881eed15-8ce8-4e8b-b85e-5838203b6681">image.png (view on web)</a> <a href="https://github.com/openstreetmap/openstreetmap-website/assets/4158490/c563252d-4428-483f-8dc2-abe7bcaa1f51">image.png (view on web)</a></p>
<p dir="auto">Also we usually add bottom margin, not both top and bottom.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4935#pullrequestreview-2157925643">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLE4UGLJN77EHLWSBTZKTF5FAVCNFSM6AAAAABKFOAMTWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJXHEZDKNRUGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPYLSCBWHVKUXI2X7LZKTF5FA5CNFSM6AAAAABKFOAMTWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUAT5KQW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4935/review/2157925643</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4935#pullrequestreview-2157925643",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4935#pullrequestreview-2157925643",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>