<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4944#discussion_r1665958689">test/controllers/changeset_comments_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -46,6 +46,14 @@ def test_feed
         assert_select "item", :count => 3
       end
     end
+
+    # Gets comment Ids from HTML and checks that they are in descending order
+    last_comment_id = -1
+    @response.body.split("Changeset comment ")[1..].each_with_index do |data, index|
+      id = Integer data.split("<")[0]
</pre>
<p dir="auto">The normal way to convert a string to an integer is to use <code class="notranslate">.to_i</code> rather than calling the constructor like this.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4944#discussion_r1665961005">test/controllers/changeset_comments_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -46,6 +46,14 @@ def test_feed
         assert_select "item", :count => 3
       end
     end
+
+    # Gets comment Ids from HTML and checks that they are in descending order
+    last_comment_id = -1
+    @response.body.split("Changeset comment ")[1..].each_with_index do |data, index|
</pre>
<p dir="auto">It would be better to test against the parsed response rather than trying to use string operations to inspect HTML embedded in feed XML from the raw response.</p>
<p dir="auto">What I'm not sure about is how easy that is when you're looking at the HTML content.</p>
<p dir="auto">I think we should certainly be able to use he parsed response to find the feed entries though even if we then extract the ID from the HTML using string operations.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4944#pullrequestreview-2159330885">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIBND3KWD3OXBZTRRDZKWC2PAVCNFSM6AAAAABKJIQHCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJZGMZTAOBYGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOMK2EI6MG2N2D6V3DZKWC2PA5CNFSM6AAAAABKJIQHCSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUAWTDEK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4944/review/2159330885</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4944#pullrequestreview-2159330885",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4944#pullrequestreview-2159330885",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>