<p></p>
<p><b>@mmd-osm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4553#discussion_r1667383647">app/abilities/ability.rb</a>:</p>
<pre style='color:#555'>> @@ -54,6 +54,7 @@ def initialize(user)
can [:index, :create, :destroy], UserMute
if user.moderator?
+ can :show_redactions, [Node, Way, Relation, OldNode, OldWay, OldRelation]
</pre>
<p dir="auto">"Node" (as in app/models/node.rb) does not have a redaction_id and does not belong to a redaction (unlike app/models/old_node.rb).</p>
<p dir="auto">Also, "Node" has no concept of "some versions", it's always the latest version of an object only, which by definition cannot be redacted. Only the "Old*" object have the full element history, including the latest version.</p>
<p dir="auto">So maybe I'm a bit confused here, because my definition of Node and OldNode is based on the model definitions.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4553#discussion_r1667383647">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK6KLV3UFP7IOCCQUTZLAFOZAVCNFSM6AAAAABEC6NWYOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRRGU2DMMBRGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLLK6UMO3C2HKNMRW3ZLAFOZA5CNFSM6AAAAABEC6NWYOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUA22JR2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4553/review/2161546013</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4553#discussion_r1667383647",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4553#discussion_r1667383647",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>