<p></p>
<p><b>@AntonKhorev</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4961#discussion_r1670490774">test/controllers/geocoder_controller_test.rb</a>:</p>
<pre style='color:#555'>> +    assert_in_delta lat, @controller.params[:lat].to_f
+    assert_in_delta lon, @controller.params[:lon].to_f
</pre>
⬇️ Suggested change
<pre style="color: #555">-    assert_in_delta lat, @controller.params[:lat].to_f
-    assert_in_delta lon, @controller.params[:lon].to_f
+    assert_match(/^[+-]?\d+(\.\d*)?$/, @controller.params[:lat])
+    assert_match(/^[+-]?\d+(\.\d*)?$/, @controller.params[:lon])
+    assert_in_delta lat, @controller.params[:lat].to_f
+    assert_in_delta lon, @controller.params[:lon].to_f
</pre>


<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4961#discussion_r1670493784">test/controllers/geocoder_controller_test.rb</a>:</p>
<pre style='color:#555'>> +    assert_in_delta lat, @controller.params[:lat].to_f
+    assert_in_delta lon, @controller.params[:lon].to_f
</pre>
⬇️ Suggested change
<pre style="color: #555">-    assert_in_delta lat, @controller.params[:lat].to_f
-    assert_in_delta lon, @controller.params[:lon].to_f
+    assert_match(/^[+-]?\d+(\.\d*)?$/, @controller.params[:lat])
+    assert_match(/^[+-]?\d+(\.\d*)?$/, @controller.params[:lon])
+    assert_in_delta lat, @controller.params[:lat].to_f
+    assert_in_delta lon, @controller.params[:lon].to_f
</pre>


<hr>

<p>On <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4961#discussion_r1670495492">test/controllers/geocoder_controller_test.rb</a>:</p>
<p dir="auto">Shouldn't we test near-zero latlon values?</p>
<div class="highlight highlight-source-ruby" dir="auto"><pre class="notranslate">  <span class="pl-c">##</span>
  <span class="pl-c"># Test identification of lat/lon pairs with values close to zero</span>
  <span class="pl-k">def</span> <span class="pl-en">test_identify_latlon_close_to_zero</span>
    <span class="pl-kos">[</span>
      <span class="pl-s">"0.00001 -0.00002"</span><span class="pl-kos">,</span>
      <span class="pl-s">"+0.00001 -0.00002"</span>
    <span class="pl-kos">]</span><span class="pl-kos">.</span><span class="pl-en">each</span> <span class="pl-k">do</span> |<span class="pl-s1">code</span>|
      <span class="pl-en">latlon_check</span> <span class="pl-s1">code</span><span class="pl-kos">,</span> <span class="pl-c1">0.00001</span><span class="pl-kos">,</span> -<span class="pl-c1">0.00002</span>
    <span class="pl-k">end</span>
  <span class="pl-k">end</span></pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4961#pullrequestreview-2166255838">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIOEHX3XUDE7MSIG53ZLPN2TAVCNFSM6AAAAABKPMSZMCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRWGI2TKOBTHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJU46O6OXBM742LORLZLPN2TA5CNFSM6AAAAABKPMSZMCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUBDZYN4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4961/review/2166255838</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4961#pullrequestreview-2166255838",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4961#pullrequestreview-2166255838",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>