<p></p>
<p><b>@AntonKhorev</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4957#discussion_r1670311643">lib/nominatim.rb</a>:</p>
<pre style='color:#555'>> @@ -11,14 +11,16 @@ def self.describe_location(lat, lon, zoom = nil, language = nil)
url = "#{Settings.nominatim_url}reverse?lat=#{lat}&lon=#{lon}&zoom=#{zoom}&accept-language=#{language}"
begin
- response = Timeout.timeout(4) do
- REXML::Document.new(Net::HTTP.get(URI.parse(url)))
+ response = OSM.http_client.get(URI.parse(url)) do |request|
+ request.timeout = 4
</pre>
<blockquote>
<p dir="auto">undefined method `timeout=' for #<struct Faraday::Request ...</p>
</blockquote>
⬇️ Suggested change
<pre style="color: #555">- request.timeout = 4
+ request.options.timeout = 4
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4957#pullrequestreview-2166004150">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLBSDUC7QYBKMQBYLLZLPAVXAVCNFSM6AAAAABKNTOOTWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRWGAYDIMJVGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMSLT753ILCKRTZ3VLZLPAVXA5CNFSM6AAAAABKNTOOTWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUBDKM3M.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4957/review/2166004150</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4957#pullrequestreview-2166004150",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4957#pullrequestreview-2166004150",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>