<p></p>
<p><b>@AntonKhorev</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4961#discussion_r1675663654">test/controllers/geocoder_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -223,6 +223,18 @@ def test_identify_latlon_sw_dms
     end
   end
 
+  ##
+  # Test identification of lat/lon pairs with values close to zero
+  def test_identify_latlon_close_to_zero
+    [
+      "0.0000123 -0.0000456",
+      "+0.0000123 -0.0000456",
+      "N 0° 0' 0.4428\", W 0° 0' 1.6416\""
+    ].each do |code|
+      latlon_check code, 0.0000123, -0.0000456
+    end
+  end
+
</pre>
<p dir="auto">This one is going to fail with <code class="notranslate">TypeError: can't convert nil into BigDecimal</code></p>
⬇️ Suggested change
<pre style="color: #555">-
+
+  ##
+  # Test identification of integer lat/lon pairs using N/E with degrees
+  def test_identify_latlon_ne_d_int_deg
+    [
+      "N50° E14°"
+    ].each do |code|
+      latlon_check code, 50, 14
+    end
+  end
</pre>

<p dir="auto"><a href="https://www.openstreetmap.org/search?query=N50%C2%B0%20E14%C2%B0" rel="nofollow">Used to work correctly</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4961#pullrequestreview-2174425331">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJJMN5PEZD2QK6JUZLZL6XCVAVCNFSM6AAAAABKPMSZMCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZUGQZDKMZTGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPJ3VAGNVBTCK6UZSTZL6XCVA5CNFSM6AAAAABKPMSZMCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUBTMMPG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4961/review/2174425331</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4961#pullrequestreview-2174425331",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4961#pullrequestreview-2174425331",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>