<p></p>
<p><b>@AntonKhorev</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4961#discussion_r1675793151">test/controllers/geocoder_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -60,6 +60,19 @@ def test_identify_latlon_ne_d
     end
   end
 
+  ##
+  # Test identification of integer lat/lon pairs using N/E with degrees
+  def test_identify_latlon_ne_d_int_deg
+    [
+      "N50 E14",
+      "N50° E14°",
+      "50N 14E",
+      "50°N 14°E"
+    ].each do |code|
+      latlon_check code, 50, 14
+    end
+  end
+
</pre>
<p dir="auto">I don't know if we want to identify these as coordinates. In this PR they fail with <code class="notranslate">ArgumentError: invalid value for BigDecimal(): "50."</code>.</p>
<ul dir="auto">
<li><code class="notranslate">N50.° E14.°</code> and <code class="notranslate">50.°N 14.°E</code> used to be not identified</li>
<li><code class="notranslate">N50. E14.</code> used to be identified with correct values</li>
<li><code class="notranslate">50.N 14.E</code> used to be identified with incorrect values</li>
</ul>
⬇️ Suggested change
<pre style="color: #555">-
+
+  def test_no_identify_latlon_ne_d_missing_fraction_part
+    [
+      # "N50. E14.", # was picked up as 50.0, 14.0
+      "N50.° E14.°",
+      # "50.N 14.E", # was picked up as 0.0, 0.0
+      "50.°N 14.°E"
+    ].each do |code|
+      get search_path(:query => code)
+      assert_response :success
+      assert_template :search
+      assert_template :layout => "map"
+      assert_equal %w[osm_nominatim], assigns(:sources).pluck(:name)
+    end
+  end
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4961#pullrequestreview-2174639852">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPZTLIAJ5SFRJA2VHDZL7FVFAVCNFSM6AAAAABKPMSZMCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZUGYZTSOBVGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLFSZ4GT5WAXTBQBKLZL7FVFA5CNFSM6AAAAABKPMSZMCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUBTZPOY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4961/review/2174639852</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4961#pullrequestreview-2174639852",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4961#pullrequestreview-2174639852",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>