<h3 dir="auto">Social Sharing Functionality:</h3>
<p dir="auto"><strong>Description:</strong><br>
This pull request enhances the social media sharing functionality for diary entries in the OpenStreetMap project, addressing issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="195640820" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/1391" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/1391/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/1391">#1391</a>. The goal is to provide users with a seamless and reliable way to share their stories on various social media platforms.</p>
<h4 dir="auto">Changes Made:</h4>
<ul dir="auto">
<li><strong>JavaScript Enhancements:</strong> Added functionality to open share URLs in pop-up windows, ensuring compatibility with various screen sizes and handling pop-up blocking scenarios.</li>
<li><strong>Ruby Helper Methods:</strong> Introduced methods to filter and validate allowed social media sites for sharing, with error logging for invalid sites or missing icons.</li>
<li><strong>Testing:</strong> Expanded test coverage to ensure the correct rendering of social share buttons and proper functionality under different configurations.</li>
</ul>
<h4 dir="auto">Purpose:</h4>
<p dir="auto">The purpose of these changes is to improve the social sharing capabilities of the application, providing a more user-friendly experience. Enhanced error handling and validation aim to increase user engagement and usability for sharing content.</p>
<h4 dir="auto">Request for Reviews:</h4>
<p dir="auto">I'm looking forward to reviews on this implementation. I aimed to make this feature reusable and intuitive, your suggestions on how to make this better are highly appreciated.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4985'>https://github.com/openstreetmap/openstreetmap-website/pull/4985</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/commits/d297e5d91e51e3dac4f187c02db4a3e2c46383ca" class="commit-link">d297e5d</a> add social sharing functionality</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files">11 files</a>)</p>
<ul>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-c25ac7e59e9436d15641c54fa9b87d98b4dad752778bbc2b70067dcca066d68e">app/assets/images/social_icons/email.svg</a>
(4)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-c5c4e0bb0e27ef1a21729f6aec9b6249e78324764d2173d62509647650522ca3">app/assets/images/social_icons/facebook.svg</a>
(4)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-c869fe797e05c3308cc1e38451313fe367e6c84b2d987763d95f03c59776604f">app/assets/images/social_icons/linkedin.svg</a>
(4)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-f0801e7ab222e01caebb482583cb8c2e6086e335ec2bdd3c42ec1664d6551506">app/assets/images/social_icons/mastodon.svg</a>
(5)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-d1f21be5850e950cfae9516b66d52e09c0933732aebabe15e8481ad058421d5e">app/assets/images/social_icons/telegram.svg</a>
(16)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-b95226034efb1268352688c3d2fb8b89ed33f87e9ca55a2e52c08055d8de7be6">app/assets/images/social_icons/twitter.svg</a>
(4)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-9e37e7466f247be7327cecd430a685e9b9ccbe305f99549e2106ee7607b91e1f">app/assets/javascripts/social_share_button.js</a>
(58)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-5f3fc5e3977d242572aa1d08551f5eb557de0ccaff30370838ee9df5386ea0da">app/helpers/application_helper.rb</a>
(42)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-19308fdc270ab97cbcfbfa5628325285149496524b767672f8e80f1079db29f9">app/views/diary_entries/_diary_entry.html.erb</a>
(10)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-415aa5ec24bcc9291bee15e94955c7488aec6e19d25f4bd8ddcecd35d5bf195b">lib/social_share_button_helper.rb</a>
(30)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985/files#diff-5aab28ad7860eb0242ea2309b822517bcb26c1ddbbb9686945b14d1fb8791f74">test/helpers/social_share_button_helper_test.rb</a>
(47)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4985.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4985.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4985.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4985.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJQI24QER347IHYV7TZMGE5HAVCNFSM6AAAAABK2RPBLKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYDOMJVGQ3DQMQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJ3FNSNXNPUXWYCX3DZMGE5HA5CNFSM6AAAAABK2RPBLKWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHI66SD7I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4985</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4985",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4985",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>