<p dir="auto">This PR addresses <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2408482737" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4989" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/4989/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/4989">#4989</a>.<br>
Errors are encountered when attempting to run <code class="notranslate">bundle exec rails eslint</code> inside the Docker container terminal,after following the instructions in the <code class="notranslate">DOCKER.md</code> file.</p>
<p dir="auto">After updating <code class="notranslate">DOCKER.md</code> to use Node.js v18, we can rebuild the container using <code class="notranslate">docker compose up --build -d </code> command. Resulting in expected result when running <code class="notranslate">bundle exec rails eslint</code></p>
<div class="highlight highlight-source-shell" dir="auto"><pre class="notranslate">$ bundle <span class="pl-c1">exec</span> rails eslint
warning: parser/current is loading parser/ruby30, which recognizes 3.0.7-compliant syntax, but you are running 3.0.2.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
yarn run v1.22.22
$ /app/node_modules/.bin/eslint -c /app/config/eslint.js /app/app/assets/config/manifest.js /app/app/assets/javascripts/application.js /app/app/assets/javascripts/auth_providers.js /app/app/assets/javascripts/diary_entry.js /app/app/assets/javascripts/fixthemap.js /app/app/assets/javascripts/id.js /app/app/assets/javascripts/index/changeset.js /app/app/assets/javascripts/index/contextmenu.js /app/app/assets/javascripts/index/directions/fossgis_osrm.js /app/app/assets/javascripts/index/directions/fossgis_valhalla.js /app/app/assets/javascripts/index/directions/graphhopper.js /app/app/assets/javascripts/index/directions.js /app/app/assets/javascripts/index/export.js /app/app/assets/javascripts/index/history.js /app/app/assets/javascripts/index/layers/data.js /app/app/assets/javascripts/index/layers/notes.js /app/app/assets/javascripts/index/new_note.js /app/app/assets/javascripts/index/note.js /app/app/assets/javascripts/index/query.js /app/app/assets/javascripts/index/search.js /app/app/assets/javascripts/index.js /app/app/assets/javascripts/leaflet.key.js /app/app/assets/javascripts/leaflet.layers.js /app/app/assets/javascripts/leaflet.locate.js /app/app/assets/javascripts/leaflet.map.js /app/app/assets/javascripts/leaflet.note.js /app/app/assets/javascripts/leaflet.query.js /app/app/assets/javascripts/leaflet.share.js /app/app/assets/javascripts/leaflet.sidebar-pane.js /app/app/assets/javascripts/leaflet.sidebar.js /app/app/assets/javascripts/leaflet.zoom.js /app/app/assets/javascripts/login.js /app/app/assets/javascripts/matomo.js /app/app/assets/javascripts/messages.js /app/app/assets/javascripts/oauth.js /app/app/assets/javascripts/richtext.js /app/app/assets/javascripts/router.js /app/app/assets/javascripts/user.js /app/app/assets/javascripts/welcome.js /app/config/eslint.js
/app/app/assets/javascripts/index.js
267:9 warning Unexpected alert no-alert
/app/app/assets/javascripts/index/directions.js
117:11 warning Unexpected alert no-alert
337:9 warning Unexpected <span class="pl-s"><span class="pl-pds">'</span>todo<span class="pl-pds">'</span></span> comment: <span class="pl-s"><span class="pl-pds">'</span>TODO: collapse width of sidebar back to...<span class="pl-pds">'</span></span> no-warning-comments
/app/app/assets/javascripts/index/directions/fossgis_osrm.js
4:1 warning Unexpected <span class="pl-k">function</span> <span class="pl-en">declaration</span> <span class="pl-k">in</span> the global scope, wrap <span class="pl-k">in</span> an IIFE <span class="pl-k">for</span> a <span class="pl-k">local</span> variable, assign as global property <span class="pl-k">for</span> a global variable no-implicit-globals
/app/app/assets/javascripts/index/directions/fossgis_valhalla.js
1:1 warning Unexpected <span class="pl-k">function</span> <span class="pl-en">declaration</span> <span class="pl-k">in</span> the global scope, wrap <span class="pl-k">in</span> an IIFE <span class="pl-k">for</span> a <span class="pl-k">local</span> variable, assign as global property <span class="pl-k">for</span> a global variable no-implicit-globals
/app/app/assets/javascripts/index/directions/graphhopper.js
1:1 warning Unexpected <span class="pl-k">function</span> <span class="pl-en">declaration</span> <span class="pl-k">in</span> the global scope, wrap <span class="pl-k">in</span> an IIFE <span class="pl-k">for</span> a <span class="pl-k">local</span> variable, assign as global property <span class="pl-k">for</span> a global variable no-implicit-globals
68:17 warning Unexpected <span class="pl-s"><span class="pl-pds">'</span>todo<span class="pl-pds">'</span></span> comment: <span class="pl-s"><span class="pl-pds">'</span>TODO does graphhopper map instructions...<span class="pl-pds">'</span></span> no-warning-comments
✖ 7 problems (0 errors, 7 warnings)
Done <span class="pl-k">in</span> 0.99s.
<span class="pl-c"><span class="pl-c">#</span> </span></pre></div>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4992'>https://github.com/openstreetmap/openstreetmap-website/pull/4992</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4992/commits/0fb6d40600689617932866be67e2d6d0b8d3f095" class="commit-link">0fb6d40</a> make docker image use nodejs v18</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4992/files">1 file</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4992/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557">Dockerfile</a>
(12)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4992.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4992.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4992.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4992.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4992">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLM5VUD5T7RFAT3AQPTZMPPLTAVCNFSM6AAAAABK4XDJKSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYDQOJVGE4DQMA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIFADJGCYPCBKCEPRLZMPPLTA5CNFSM6AAAAABK4XDJKSWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHI7FNQJA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4992</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4992",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4992",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>