<p dir="auto">I'm not sure what was <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4944#discussion_r1665980153" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4944/hovercard">that</a> about because comment ids are not inside CDATA or HTML or <code class="notranslate"><description></code>, but rather inside <code class="notranslate"><link></code> or <code class="notranslate"><guid></code>:</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/fcca9f24-7e00-424c-aee0-c990e93ca972">image.png (view on web)</a></p>
<p dir="auto">The test picked numbers from<br>
<a href="https://github.com/openstreetmap/openstreetmap-website/blob/a3441739ca4b70ee634e4e3c29415efe738df52e/test/factories/diary_comments.rb#L3">https://github.com/openstreetmap/openstreetmap-website/blob/a3441739ca4b70ee634e4e3c29415efe738df52e/test/factories/diary_comments.rb#L3</a><br>
which happens to also work because if they are descending so do the ids. But it's more complicated because of extra html parsing and more confusing because these numbers are called id yet they are not.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4991'>https://github.com/openstreetmap/openstreetmap-website/pull/4991</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4991/commits/0f63f0fd3da83c7dfee2abb77026c061b694fc49" class="commit-link">0f63f0f</a>  Check comment ids instead of factory sequence numbers in changeset feed tests</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4991/files">1 file</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4991/files#diff-21ed1f116916c6991487f8c1708bfdcdc0408134a9ea703c7bb8c0e95bc018da">test/controllers/changeset_comments_controller_test.rb</a>
    (27)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4991.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4991.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4991.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4991.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4991">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN5ZBABO63YJGVJZPTZMPN2DAVCNFSM6AAAAABK4WLJGOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYDQOJSGE3TEOA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLINT34QM3J6DI26MXTZMPN2DA5CNFSM6AAAAABK4WLJGOWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHI7FJ2QA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4991</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4991",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4991",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>