<p></p>
<p dir="auto">Try to add a "sleep 10" right before <code class="notranslate">@note.close</code> and then test in two different browser windows. Without explicit locking you can resolve the note twice, with locking in place the second resolve attempt fails with an error message "The note xxx was closed at yyy UTC".</p>
<p dir="auto">It would probably be better to use optimistic locking in this case, since conflicts should be extremely rare. On the other hand, our Note model doesn't have a lock_version field, which is needed according to <a href="https://api.rubyonrails.org/classes/ActiveRecord/Locking/Optimistic.html" rel="nofollow">https://api.rubyonrails.org/classes/ActiveRecord/Locking/Optimistic.html</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/4528#issuecomment-2231414812">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJPPESFOL7PHEEXXTLZMVHGHAVCNFSM6AAAAABDOU4LYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGQYTIOBRGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLLJPU2L7KAFZAX2ITZMVHGHA5CNFSM6AAAAABDOU4LYOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUFACYBY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/4528/2231414812</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/4528#issuecomment-2231414812",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/4528#issuecomment-2231414812",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>