<p dir="auto"><code class="notranslate">_auth_providers.html.erb</code> iterates over <code class="notranslate">%w[google facebook microsoft github wikipedia]</code> and checks which provider is available. But the <code class="notranslate">Auth</code> module already does that. <code class="notranslate">Auth</code> is only used on account settings pages and has a "provider" "None" specific to these pages. If "None" is removed, <code class="notranslate">Auth</code> can be reused in <code class="notranslate">_auth_providers.html.erb</code>.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5002'>https://github.com/openstreetmap/openstreetmap-website/pull/5002</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5002/commits/c3ad502f90363f3507a86fd1bcc778b98c7118e2" class="commit-link">c3ad502</a> Remove 'None' from auth providers</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5002/commits/5b30e903794c341084cb2162c927bc4f17f8f2cd" class="commit-link">5b30e90</a> Use Auth.providers in auth providers template</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5002/files">3 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5002/files#diff-e60a309ef4c891e6cb7845dfcb970684e61c569372bb66ea1ac9c3a16e699eac">app/views/accounts/edit.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5002/files#diff-5a9b0e7aa9d3862ba8103db51b8b44b6e392cb43f22bba850bf95e0be7b53e4f">app/views/application/_auth_providers.html.erb</a>
(35)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5002/files#diff-42ba58b2050212a385282d51fd9edfd64ef3ad90633f6e8ea9359137d0128a15">lib/auth.rb</a>
(1)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5002.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5002.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5002.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5002.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5002">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOJUEO55EY54R6WJADZM63GZAVCNFSM6AAAAABLCTZFYWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTMMRYHA2DGNQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPFYYMRANDELPR2MUDZM63GZA5CNFSM6AAAAABLCTZFYWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJABNCWQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5002</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5002",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5002",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>