<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5030#discussion_r1696137112">app/helpers/trace_helper.rb</a>:</p>
<pre style='color:#555'>> +  def trace_image(trace, options = {})
+    options[:class] ||= "trace_image"
+    options[:alt] ||= ""
+
+    link_to(image_tag(trace_icon_path(trace.user, trace),
+                      options.merge(:width => 50, :height => 50)),
+            show_trace_path(trace.user, trace),
+            :class => "d-inline-block")
+  end
</pre>
<p dir="auto">Do we really need a helper for this? If it's supposed to be reusable, why <code class="notranslate">d-inline-block</code> is baked into the link?</p>
<p dir="auto">Why the name <code class="notranslate">trace_image</code>? There are two trace images, the name doesn't tell which one this is. Why "image" if it returns a link?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5030#pullrequestreview-2206378983">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOGEFNKQIWYI3DUFDDZO3QN5AVCNFSM6AAAAABLU3HX5SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBWGM3TQOJYGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPOIGX75UKXKLW3SY3ZO3QN5A5CNFSM6AAAAABLU3HX5SWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUDQKV6O.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5030/review/2206378983</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5030#pullrequestreview-2206378983",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5030#pullrequestreview-2206378983",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>