<p></p>
<p><b>@mmd-osm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5038#discussion_r1703210313">app/models/trace.rb</a>:</p>
<pre style='color:#555'>>          tracepoints.each do |tp|
           tp.run_callbacks(:save) { false }
           tp.run_callbacks(:create) { false }
         end
 
-        Tracepoint.import!(tracepoints)
+        Tracepoint.insert_all!(tracepoints.map(&:attributes))
</pre>
<p dir="auto">Good idea, I've added some unit tests for the API endpoint. It's a bit unfortunate though, that lat/lon values are identical in  <code class="notranslate">a.gpx</code>.</p>
<p dir="auto">I've also added a call to <code class="notranslate">validate!</code>. I'm not sure if this whole validation is working as expected. Like before, I'm getting import failures in case the timestamp is missing, which is good. However, missing lat/lon values are not reported neither in the current code nor in the updated version in this PR.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5038#discussion_r1703210313">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMBHR7YJPOUDBS3W3LZPYWMNAVCNFSM6AAAAABL3DDMS6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJXG42TKNBZGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIDYWMVKNJR7C7ADJ3ZPYWMNA5CNFSM6AAAAABL3DDMS6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUEGBBWI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5038/review/2217755492</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5038#discussion_r1703210313",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5038#discussion_r1703210313",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>