<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5045#discussion_r1704743482">app/views/api/changesets/index.xml.builder</a>:</p>
<pre style='color:#555'>>  xml.osm(OSM::API.new.xml_root_attributes) do |osm|
-  @changesets.each do |changeset|
-    osm << render(changeset)
-  end
+  osm << (render(@changesets) || "")
</pre>
<p dir="auto">Do we need this <code class="notranslate">|| ""</code>?</p>
<p dir="auto"><code class="notranslate">render(@changesets)</code> returns <code class="notranslate">nil</code> on empty set, then <code class="notranslate">nil</code> gets appended to a stream which should work fine:</p>
<p dir="auto"><a href="https://github.com/rails/builder/blob/789896b306e36a5fe166388413b16e9323260601/lib/builder/xmlbase.rb#L116">https://github.com/rails/builder/blob/789896b306e36a5fe166388413b16e9323260601/lib/builder/xmlbase.rb#L116</a><br>
<a href="https://github.com/rails/rails/blob/9ba208c16835f4a174ae9fd385ebc18972d758a4/actionview/lib/action_view/buffers.rb#L97">https://github.com/rails/rails/blob/9ba208c16835f4a174ae9fd385ebc18972d758a4/actionview/lib/action_view/buffers.rb#L97</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5045#pullrequestreview-2220031870">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL5B22Y6NGMMOGZFPLZQAHZXAVCNFSM6AAAAABL7EIANGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRQGAZTCOBXGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNTRVPRHAYXLDKF4S3ZQAHZXA5CNFSM6AAAAABL7EIANGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUEKL7X4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5045/review/2220031870</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5045#pullrequestreview-2220031870",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5045#pullrequestreview-2220031870",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>