<p dir="auto">I don't know if we're ready to pull this trigger yet so I'll open this as draft for now but this is the proposed removal of the OAuth 1 code.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5058'>https://github.com/openstreetmap/openstreetmap-website/pull/5058</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/commits/4dc5116bf62324baa350557cdf3e43ba10170454" class="commit-link">4dc5116</a> Drop support for OAuth 1</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files">47 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-d09ea66f8227784ff4393d88a19836f321c915ae10031d16c93d67e6283ab55f">Gemfile</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-89cade48462044ee1b672dc5f4c3ec250fbd29effcd8932096a23c1283c6731f">Gemfile.lock</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-debf59904131dc89a88ab44cbb1d6deaaa5a7d70c0507f674080df62f7c8e41f">app/abilities/ability.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-25fe163085ea55de795324d01f141d5e4de00c6a2d3035d75c6e0768af679a2e">app/controllers/accounts_controller.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-6e9fe051c0ef757618e376ffe731dfca8d4960ef0838b7d6a05609b46ba0fad1">app/controllers/api/notes_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-d76849254c4029831b9937fe42b80584a783751f4ba52e254ccaad44beca47e0">app/controllers/api/permissions_controller.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-380aab66173996fadff8576f19062da8bacc45be57582f15afb9fd46c411cbbf">app/controllers/api_controller.rb</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-766c34fd6533171eaf54300c153f89d6002c35c02cfc9c5b219251f85180ad07">app/controllers/application_controller.rb</a>
(11)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-e712a8df307b530ca702e97779daa3400119cc79eb20d81afa5efb1f9909b0fb">app/controllers/oauth_clients_controller.rb</a>
(75)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-a6d245a96660f22327520216be9996a9f9375865fae7d8daca39cb041e43267c">app/controllers/oauth_controller.rb</a>
(80)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-428acb6c9bafa225cc8dfc426142534aa102be5d4291707ee2d43f528b7bea1e">app/models/access_token.rb</a>
(57)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-2ca3a978e5b6e4fee47713d116f75573a7768194f4b0f111deadd08f7a23dc04">app/models/client_application.rb</a>
(109)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-111bed9b659914f351acb869bb7a6913329912f1ad10a16336fff64a4feedd44">app/models/oauth2_token.rb</a>
(58)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-6b3f905f2e71651516335e807cd3dbb677f615f1921dca805d456b9522ef39a3">app/models/oauth2_verifier.rb</a>
(72)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-4ac31a613bb5faf83f0945ee44a63a8feebfde53d5285ad88856650b46cc8e43">app/models/oauth_nonce.rb</a>
(31)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-4a4e54eec60e3324b16652796e58be94424789ecd652cbe81da5ac72689f9f24">app/models/oauth_token.rb</a>
(72)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-eb020aecdf3439e1df911e2eae3f49dd9b692dd8c647d12262dbda45eb2bbff6">app/models/request_token.rb</a>
(82)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-9802ca3c9c4cf89904fd44bc114e35ebdf2c5dd3d5b645491e2b253e1afef29b">app/models/user.rb</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-90d570948841d78bc3498101a4090ca4b95c73dad7762210d46cff8e1343a262">app/views/application/_settings_menu.html.erb</a>
(3)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-97d1c142bd27c41ca579dbf01a0e513ec0439971066c96f4e2ee0873240cab4d">app/views/oauth/authorize.html.erb</a>
(18)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-006943da9a9507cd5a257e50f294348705a9a2e1a40ca4465fd242190c516ca1">app/views/oauth/authorize_failure.html.erb</a>
(5)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-0720f28430d7222238c4b2519f61c01e2ae8b87480aa78782c9efc5f43af5189">app/views/oauth/authorize_success.html.erb</a>
(9)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-4279172d81d80e24a02d54d1c0e3d3f3db54dbd06ded34239dbb83d210d0a5b6">app/views/oauth_clients/_form.html.erb</a>
(11)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-a0a7419fc0df83b395310003eed9c8253cf4b78ea75d32e908c96a661159357c">app/views/oauth_clients/edit.html.erb</a>
(9)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-092ad2f67379cb50166c192945796d738f36641c07a73bec0b1b2640221849a4">app/views/oauth_clients/index.html.erb</a>
(47)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-0013c7688112c16c79b4382452995c1666f6b9cdf1b60b952a94ac60da81a2c2">app/views/oauth_clients/new.html.erb</a>
(9)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-1e49c6fba9b4605f1cd24fd7b94f4b389be3f494dc44c370f3f35f4efc8f9871">app/views/oauth_clients/not_found.erb</a>
(1)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-87d051f6ea1fffd530bf249150840ddbd9d7e3e96ffc89914caada00889ec9e8">app/views/oauth_clients/show.html.erb</a>
(33)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-3c3ca714fc7e74ff7a103d06297415eec83e8d2ee5cdbb6b16c0ccb605a82f89">config/initializers/oauth.rb</a>
(90)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(65)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-e769bbb8c1ba3711c5403b424ed9c218ffafba7f1890ee394717196f28ff4540">config/settings.yml</a>
(6)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-b0d4a6e924ccaf597bb83e5cdb01b34abfae9c154be5cd0b487825ade4a38219">db/migrate/20240724194738_drop_oauth1_tables.rb</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-1dd5a8f580b9615769ddc19a64a98f455d9d20eb149c443f41d9d3c797d39b12">db/structure.sql</a>
(231)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-18d576125e0eb6b76ee5efcf04ddeb859061ad7336a4800411e5ef226d042f7a">script/cleanup</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-9f754279838a5317ec8ed3ecfebfe2b3b409d3464b7aac738290fbac0640d7a6">test/controllers/api/permissions_controller_test.rb</a>
(27)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-fa16feb2449d85c917bc2295eb0c38b60b48ec9415f160319d8b10b9f97ea0f7">test/controllers/api/users_controller_test.rb</a>
(206)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-742315c0f3a9cac77152fcec6dd67be79976d63eec04c60c6581ec6ab1da78c0">test/controllers/oauth_clients_controller_test.rb</a>
(204)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-47af90a3bbfa2c2d5e2c7e12dc664b7c9cf31b9b5b06295c4b95063c56c7911c">test/controllers/oauth_controller_test.rb</a>
(48)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-af2a9eac5327b742c2cbff375c8425b65985746bf17d6fe3feb245127131bae4">test/factories/client_applications.rb</a>
(8)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-b06fdb1b027508cfa9d420409eeb1db54c3e81d51e16c5a6b55a53cb05efe047">test/integration/client_applications_test.rb</a>
(91)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-87fe3fac4587fa15b3cb6515833a8aa7ca75f79f136bfb1f3ab51ef6bbba9f82">test/integration/oauth_test.rb</a>
(421)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-1ef888d717e6c2879e02615b3bc9510d966bb3329888eca5ff4d760b7166d460">test/models/client_application_test.rb</a>
(54)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-7cf8cb05ab28754ccad95e0a61591752d6fcafd124cfaae45fee12e62f5350b7">test/models/oauth_nonce_test.rb</a>
(29)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-9ed24267e574df2d6b1a08918227fce884dbcaa7cf91e60d0141a3053d620c44">test/models/oauth_token_test.rb</a>
(23)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-3870b3ca8ecd9b6f8a3f35a2944aceddf5c795c100745faed3c62f3c918aed47">test/models/request_token_test.rb</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058/files#diff-91bef9fda3c55514e23a4a8edba948f68aad59b57951adcff0b11e9ea9159854">test/models/user_test.rb</a>
(12)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5058.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5058.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5058.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5058.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5058">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLILWIIXVKAVNZ57QQ3ZQJOC5AVCNFSM6AAAAABME44IOKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TIMBTGI4DAOI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIQXZPCQ6F24XJXNWTZQJOC5A5CNFSM6AAAAABME44IOKWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJERMRVE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5058</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5058",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5058",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>