<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5056#discussion_r1707127268">app/helpers/open_graph_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -1,15 +1,15 @@
 module OpenGraphHelper
   require "addressable/uri"
 
-  def opengraph_tags(title = nil, og_image = nil, og_image_alt = nil)
+  def opengraph_tags(title = nil, properties = {})
</pre>
<p dir="auto">This helper is only called in one place in the codebase, and it is called with two parameters. So the defaults never apply. They can be omitted entirely.</p>
<p dir="auto">Even if you call it as <code class="notranslate">opengraph_tags(nil, nil)</code> (or things that evaluate to nil, like an undefined instance variable) then <code class="notranslate">properties</code> will be <code class="notranslate">nil</code>, not <code class="notranslate">{}</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5056#pullrequestreview-2225385687">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLM55TRC7M7LV66JM4TZQIVWBAVCNFSM6AAAAABMDVA4IOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRVGM4DKNRYG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMTLBFMTSG6V6M5X3LZQIVWBA5CNFSM6AAAAABMDVA4IOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUEUSYNO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5056/review/2225385687</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5056#pullrequestreview-2225385687",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5056#pullrequestreview-2225385687",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>